[Fast-reboot]: Gracefully shutdown syncd in fast-reboot #212
Conversation
scripts/fast-reboot
Outdated
| docker kill swss > /dev/null | ||
|
|
||
| # Gracefully stop syncd | ||
| docker exec -ti syncd /usr/bin/syncd_request_shutdown --cold > /dev/null |
There was a problem hiding this comment.
will this break the mellanox platform?
There was a problem hiding this comment.
It will not. Currently there're no remove_switch() in syncd.
I'm going to add remove_switch for Broadcom only.
There was a problem hiding this comment.
I see. I missed the other change. Sorry.
Regards,
Ying
|
Please don't merge it.
|
scripts/fast-reboot
Outdated
| docker exec -ti syncd /usr/bin/syncd_request_shutdown --cold > /dev/null | ||
|
|
||
| # Check it was stopped | ||
| until [[ $(docker top syncd | grep -q /usr/bin/syncd) -eq 0 ]] |
There was a problem hiding this comment.
I think you need to s/-q/-c/
There was a problem hiding this comment.
Both grep -q and grep -c will return 0 if any matches are found, and will return 1 if no matches are found.
Therefore, either are applicable, however, the condition needs to be changed to either
until [[ $(docker top syncd | grep -q /usr/bin/syncd) -eq 1 ]]
or
while [[ $(docker top syncd | grep -q /usr/bin/syncd) -eq 0 ]]
There was a problem hiding this comment.
$(...) is getting the output of the execution. Therefore, with -q it is always ''.
With -c, the output would be how many lines found. We want to wait until there is 0 lines.
So, it would be prudent to redirect 2&> /dev/null for "docker top syncd" though for fast_reboot scenario, it is highly unlikely that the docker is not running.
There was a problem hiding this comment.
You're right, Ying. For some reason I was fixated on the return value, not the stdout output.
scripts/fast-reboot
Outdated
| docker kill swss > /dev/null | ||
|
|
||
| # Gracefully stop syncd | ||
| docker exec -ti syncd /usr/bin/syncd_request_shutdown --cold > /dev/null |
There was a problem hiding this comment.
I see. I missed the other change. Sorry.
Regards,
Ying
RB=1288101
G=lnos-reviewers
R=ntrianta,pmao,rmolina,sfardeen,zxu
* github:
[acl_loader] Support Service ACL binding to multiple services (sonic-net#236)
[show] Rename 'show session' to 'show mirror session' (sonic-net#235)
[pfcstat]: create python cli tool to show pfc counters (sonic-net#233)
[queuestat] add python CLI tool to show queue counters
[acl-loader] Not to crash upon invalid rule (sonic-net#232)
Show FDB type in fdbshow/show mac (sonic-net#231)
[show] add 'show runningconfiguration all' subcommand (sonic-net#230)
[reboot scripts] remove -t option in docker exec commands (sonic-net#228)
[reboot] reduce stop service to only stop syncd (sonic-net#223)
[crm]: Fix failures in CLI show commands (sonic-net#221)
[Fast-reboot]: Gracefully shutdown syncd in fast-reboot (sonic-net#212)
add fast-reboot support for nephos platform by stop kernel modules (sonic-net#220)
[config bgp] Convert user input ipv6 addr to lower case before comparing (sonic-net#218)
[PFCWD]: set default configuration when enabled by default (sonic-net#213)
Add fast-reboot support for Aboot based images (sonic-net#214)
sonic-utilities: Format show vlan config output (sonic-net#210)
[AAA] Support login(ascii) authentication type (sonic-net#217)
[sfputil] Adapt new way of getting PLATFORM(sonic-net#216)
[Fast-Reboot]: Adapt fast-reboot-dump script for SAIv1.2 (sonic-net#211)
Refactor fast-reboot script. Generate fast-reboot-dumps into configurable directory (sonic-net#208)
Find correct opennsl module name before stopping it (sonic-net#207)
[crm]: Add utility for CRM configuration (sonic-net#187)
[reboot] update reboot script to retrieve platform with new format (sonic-net#206)
Adapt to config engine change to load platform info properly (sonic-net#205)
[config] Add qos clear and qos reload support (sonic-net#204)
Dump default routes from APPL_DB table before fast-reboot (sonic-net#203)
[acl_loader] Fix a crash issue when appdb is not consistent with cfgdb (sonic-net#202)
[pfcwd]: add command to set pfcwd polling interval (sonic-net#192)
[acl-loader] Prevent from hanging if run by non-root user (sonic-net#199)
[config] Store ConfigDB init indicator boolean value as 1/0 in Redis to be language-agnostic (sonic-net#197)
Get Vlan Id from SAI Vlan Object if bvid present (sonic-net#196)
[TACACS+]: Fix aaa show error without configuration (sonic-net#191)
'config bgp [shutdown|startup] neighbor <hostname>' now affects all sessions for neighbor (sonic-net#195)
[sonic-clear] add a clear fdb command (sonic-net#186)
- What I did
Add a feature to gracefully shutdown syncd
- How I did it
Using syncd_request_shutdown utility
- How to verify it
Run fast-reboot test
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
-->