Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed db_migrator version 4_0_3 and 4_0_4 and added missing log info to version 4_0_1 #2912

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

MuhammadUmarAsad
Copy link
Contributor

What I did

In PR #2893 the db_migrator "migrate_dns_nameserver" was misplaced in the latest version being version 4_0_4 instead of being placed in version 4_0_3.

Additionally, the log info for version 4_0_1 was missing as well

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

…0_4 and added missing log info to version 4_0_1
@MuhammadUmarAsad
Copy link
Contributor Author

@qiluo-msft can you review this PR?

@MuhammadUmarAsad
Copy link
Contributor Author

@vaibhavhd pls review this PR

@MuhammadUmarAsad
Copy link
Contributor Author

@qiluo-msft can you merge this?

@qiluo-msft qiluo-msft merged commit 42cba90 into sonic-net:master Jul 20, 2023
4 checks passed
rajkumar38 pushed a commit to rajkumar38/sonic-utilities that referenced this pull request Jul 25, 2023
…to version 4_0_1 (sonic-net#2912)

#### What I did

In PR sonic-net#2893 the db_migrator "migrate_dns_nameserver" was misplaced in the latest version being version 4_0_4 instead of being placed in version 4_0_3. 

Additionally, the log info for version 4_0_1 was missing as well
pdhruv-marvell pushed a commit to pdhruv-marvell/sonic-utilities that referenced this pull request Aug 23, 2023
…to version 4_0_1 (sonic-net#2912)

#### What I did

In PR sonic-net#2893 the db_migrator "migrate_dns_nameserver" was misplaced in the latest version being version 4_0_4 instead of being placed in version 4_0_3. 

Additionally, the log info for version 4_0_1 was missing as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants