Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of usability improvements, some bug fixes and functional enhancements #56

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Commits on Mar 28, 2017

  1. Use argparse for parsing command line

    In preparation for adding a configuration file and command-line
    arguments, add code to use argparse to parse the command line. This is
    at this point nonfunctional with the exception that the code now
    enforces exactly the correct number of arguments on the command line
    rather than silently ignoring extra arguments.
    Jonathan Kamens committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    c07f9b5 View commit details
    Browse the repository at this point in the history
  2. Specify username on command line instead of hard-coding

    Jonathan Kamens committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    12430ea View commit details
    Browse the repository at this point in the history
  3. Allow username to be specified in INI file

    Jonathan Kamens committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    3a93125 View commit details
    Browse the repository at this point in the history
  4. Make Android ID parameterized

    Allow the Android ID to be specified in the configuration file or on
    the command line, or randomly generated and saved in the configuration
    file automatically.
    Jonathan Kamens committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    52bbba5 View commit details
    Browse the repository at this point in the history
  5. Allow playlists to be replaced on import

    Jonathan Kamens committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    156a815 View commit details
    Browse the repository at this point in the history
  6. Don't use storeId

    The code was using the storeId field in songs to import them, when it
    existed. I don't know why it was doing that, but it wasn't working for
    me -- songs added via storeId simply weren't appearing in my
    playlists. Removing that logic and always using the id, never the
    storeId, fixed this problem. This change may not be "correct", but all
    I know is that the code wasn't working for me without the change and
    is working with it.
    Jonathan Kamens committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    583f17c View commit details
    Browse the repository at this point in the history
  7. Allow password to be specified in configuration file

    Jonathan Kamens committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    993c10f View commit details
    Browse the repository at this point in the history
  8. Be smarter about picking the best match and dropping duplicates

    When searching for a track, if there are multiple matches and some of
    them are already selected, then use the ones that aren't.
    
    When there are multiple search results, prefer exact matches rather
    than substring matches for title, album, artist.
    Jonathan Kamens committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    108cd2b View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2017

  1. Fix best_match traceback when there are no matches

    Jonathan Kamens committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    17d8ede View commit details
    Browse the repository at this point in the history