Update again + the component, too

sourcegraph · Jun 19, 2024 · f275393 · f275393
1 parent d8e5043
commit f275393
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 20 deletions.
diff --git a/client/web/src/cody/management/api/react-query/teams.ts b/client/web/src/cody/management/api/react-query/teams.ts
@@ -30,7 +30,6 @@ export const useUpdateTeamMember = (): UseMutationResult<TeamMember[], Error, Up
  },
  onSuccess: (data: TeamMember[]) => {
  queryClient.setQueryData(queryKeys.teams.teamMembers(), data)
- return queryClient.invalidateQueries({ queryKey: queryKeys.teams.teamMembers() })
  },
  })
 }
diff --git a/client/web/src/cody/team/TeamMemberList.tsx b/client/web/src/cody/team/TeamMemberList.tsx
@@ -55,19 +55,11 @@ export const TeamMemberList: FunctionComponent<TeamMemberListProps> = ({
  })
 
  try {
- const response = await updateTeamMemberMutation.mutateAsync.call(undefined, {
+ await updateTeamMemberMutation.mutateAsync.call(undefined, {
  updateMemberRole: { accountId, teamRole: newRole },
  })
- if (!response.ok) {
- setLoading(false)
- setActionResult({
- message: `We couldn't modify the user's role (${response.status}). Please try again later.`,
- isError: true,
- })
- } else {
- setLoading(false)
- setActionResult({ message: 'Team role updated.', isError: false })
- }
+ setLoading(false)
+ setActionResult({ message: 'Team role updated.', isError: false })
  } catch (error) {
  setLoading(false)
  setActionResult({
@@ -134,18 +126,18 @@ export const TeamMemberList: FunctionComponent<TeamMemberListProps> = ({
  setLoading(true)
  telemetryRecorder.recordEvent('cody.team.removeMember', 'click', { privateMetadata: { teamId } })
 
- const response = await updateTeamMemberMutation.mutateAsync.call(undefined, {
- removeMember: { accountId, teamRole: 'member' },
- })
- if (!response.ok) {
+ try {
+ await updateTeamMemberMutation.mutateAsync.call(undefined, {
+ removeMember: { accountId, teamRole: 'member' },
+ })
+ setLoading(false)
+ setActionResult({ message: 'Team member removed.', isError: false })
+ } catch (error) {
  setLoading(false)
  setActionResult({
- message: `We couldn't remove the team member. (${response.status}). Please try again later.`,
+ message: `We couldn't remove the team member. (${error}). Please try again later.`,
  isError: true,
  })
- } else {
- setLoading(false)
- setActionResult({ message: 'Team member removed.', isError: false })
  }
  }
  },