Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Hover is not unpinned even when it is empty #4940

Closed
lguychard opened this issue Jul 18, 2019 · 0 comments · Fixed by sourcegraph/codeintellify#157
Closed

Hover is not unpinned even when it is empty #4940

lguychard opened this issue Jul 18, 2019 · 0 comments · Fixed by sourcegraph/codeintellify#157
Assignees
@lguychard
Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior.

Comments

@lguychard
Copy link
Contributor

lguychard commented Jul 18, 2019 •
edited
Loading

Steps to reproduce:

  1. Sync https://bitbucket.sgdev.org/projects/SOUR/repos/vegeta to a Sourcegraph instance.
  2. Navigate to http://localhost:3080/bitbucket.sgdev.org/SOUR/vegeta/-/blob/lib/targets.go#L137:17, with basic code intel activated.
  3. Click on Lexer at line 137.
  4. Hover jlexer at line 137, without clicking.

Expected behavior:

Hover overlay appears for jlexer:

image

Actual behavior:

No hover overlay appears for jlexer, or any other symbol, unless you unpin the hover overlay.

This is because getHoverActions() emits an empty array instead of null when no hover actions are contributed, which trips up codeintellify's unpinning logic (rel sourcegraph/codeintellify#156)
@lguychard lguychard added bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. code-nav labels Jul 18, 2019
@lguychard lguychard self-assigned this Jul 18, 2019
@lguychard lguychard mentioned this issue Jul 18, 2019
Closed
felixfbecker referenced this issue in sourcegraph/codeintellify Jul 18, 2019
@felixfbecker
fix: unpin when actions are empty array
89dfbb1 
Fixes https:/sourcegraph/sourcegraph/issues/4940
@felixfbecker felixfbecker mentioned this issue Jul 18, 2019
Merged
felixfbecker referenced this issue in sourcegraph/codeintellify Jul 18, 2019
@felixfbecker
fix: unpin when actions are empty array
f8cfd26 
Fixes https:/sourcegraph/sourcegraph/issues/4940
felixfbecker referenced this issue in sourcegraph/codeintellify Jul 18, 2019
@felixfbecker
fix: unpin when actions are empty array (#157)
b8a2208 
Fixes https:/sourcegraph/sourcegraph/issues/4940
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lguychard lguychard

Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior.
Projects
None yet
Milestone
No milestone
1 participant
@lguychard