Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You will want to review commit by commit
Some commits are
lint:fix
-only, so those can be skipped.The main things no note that changed are:
Note on the lint package:
This is based off getting compatibility with the future of eslint, which is overrides only, and inline with the "one lint config" approach, documented here: embroider-build/addon-blueprint#71 (comment)
the lint package used will likely soon emit config to demonstrate how this works.
Here are docs on eslint and their new config format: https://eslint.org/docs/latest/use/configure/configuration-files-new
In fact, the way the new docs say to share configs, is exactly what I'm proposing here in the above issue on the v2 addon blueprint 🎉 https://eslint.org/docs/latest/use/configure/configuration-files-new#using-predefined-configurations
Why did this happen?
A bit of a cascade from adding new project,
ember-scoped-css-compat
to this PR: #46It pulls in newer lint dependencies, which due to how pnpm hoists eslint and prettier dependencies (because eslint and prettier do dirty things with dep expectations) (yarn style) -- eslint 7 and eslint 8 are not safely usable in the same monorepo together (not easily).
It was far quicker for me to upgrade everything to eslint 8 and use the latest style of linting (also splitting prettier out to its own command).
This can later be orchestrated via
turbo
, for aggressive caching.Since I'm splitting up #46,