Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update infra #47

Merged
merged 10 commits into from
Jun 12, 2023
Merged

Update infra #47

merged 10 commits into from
Jun 12, 2023

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Jun 9, 2023

You will want to review commit by commit

Some commits are lint:fix-only, so those can be skipped.
The main things no note that changed are:

  • import sort order is enforced
  • there are more linebreaks to enhance scannability.

Note on the lint package:

This is based off getting compatibility with the future of eslint, which is overrides only, and inline with the "one lint config" approach, documented here: embroider-build/addon-blueprint#71 (comment)
the lint package used will likely soon emit config to demonstrate how this works.

Here are docs on eslint and their new config format: https://eslint.org/docs/latest/use/configure/configuration-files-new
In fact, the way the new docs say to share configs, is exactly what I'm proposing here in the above issue on the v2 addon blueprint 🎉 https://eslint.org/docs/latest/use/configure/configuration-files-new#using-predefined-configurations


Why did this happen?

A bit of a cascade from adding new project, ember-scoped-css-compat to this PR: #46
It pulls in newer lint dependencies, which due to how pnpm hoists eslint and prettier dependencies (because eslint and prettier do dirty things with dep expectations) (yarn style) -- eslint 7 and eslint 8 are not safely usable in the same monorepo together (not easily).
It was far quicker for me to upgrade everything to eslint 8 and use the latest style of linting (also splitting prettier out to its own command).

This can later be orchestrated via turbo, for aggressive caching.

Since I'm splitting up #46,

  • the next PR will be to add the compat addon
  • after that will be the embroider fix

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review June 9, 2023 20:54
@alexspeller
Copy link

LGTM

@NullVoxPopuli NullVoxPopuli merged commit 6a9e175 into main Jun 12, 2023
@NullVoxPopuli NullVoxPopuli deleted the update-infra branch June 12, 2023 14:05
@NullVoxPopuli NullVoxPopuli mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants