Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New Update Available" toast not disappearing after update #2519

Closed
zaaakher opened this issue May 29, 2024 · 9 comments
Closed

"New Update Available" toast not disappearing after update #2519

zaaakher opened this issue May 29, 2024 · 9 comments
Assignees

Comments

@zaaakher
Copy link
Contributor

Describe the bug

I got a toast in the bottom right corner telling me there's a new update. After clicking on "update" and going to through the wizard and SpaceDrive opens up again the toast shows up again telling me to update again even though SpaceDrive is already the latest version.

I actually fell for it and updated SpaceDrive twice 😅

image

Reproduction

  1. Make sure your SpaceDrive app is not up to date.
  2. You'll see a "New Update Available" toast on the bottom right corner
  3. Click on the "update" action button in that toast and go through the installation wizard
  4. SpaceDrive will open up again after the update ( or you can open SpaceDrive manually)
  5. You'll see the toast again even though your SpaceDrive is up to date.

Expected behavior

The "New Update Available" toast should not appear again after updating SpaceDrive.

I think there should be a check to see if the SpaceDrive version the user has is up to date or not. If so, then don't show the toast, otherwise keep showing it every time they open the SpaceDrive app.

Platform and versions

Windows 10 Pro (Build 19045.4291)
pnpm: v9.1.3
cargo: n/a
rustc: n/a

Stack trace

No response

Additional context

No response

@zaaakher zaaakher added kind/bug Something isn't working status/needs-triage labels May 29, 2024
@zaaakher zaaakher changed the title [BUG] "New Update Available" toast not disappearing after update "New Update Available" toast not disappearing after update May 29, 2024
@zaaakher
Copy link
Contributor Author

I noticed the same thing with the "Install Update" button on the side menu. 👇 It seems to be that the function that detects if the app needs to be updated is not really detecting the current version of my app and matching it with the actual latest release of the SpaceDrive

image

@zaaakher
Copy link
Contributor Author

Tracing the issue back to where it could potentially be from:

Either from the desktop updater in desktop/src/updater.tsx

Or from the tauri updater in desktop/src-tauri/src/updater.rs

@HeavenVolkoff
Copy link
Member

I think this was solved by #2517, I am building a test release rn to make sure, will post the link here when it is available so any people experiencing this can test.

@HeavenVolkoff
Copy link
Member

The test release is available here:
https:/spacedriveapp/spacedrive/actions/runs/9292624870

@zaaakher
Copy link
Contributor Author

zaaakher commented May 30, 2024

@HeavenVolkoff ok I downloaded the Spacedrive-windows-x86_64.msi file and installed it. Seems to be working fine with no toast or any msg telling me to update 👍

Although on a side note that could be irrelevant:
During the installation of that test release I got this warning

image

@davidjaggi
Copy link

I experience the same issue. This was also an issue in an earlier release but the solved via an update.

@ketonik
Copy link

ketonik commented May 30, 2024

Nice work guys, resolved for me too
Spacedrive-windows-x86_64.msi
at
https:/spacedriveapp/spacedrive/actions/runs/9292624870/artifacts/1550110422

Edition Windows 11 Pro for Workstations
Version 23H2
Installed on ‎30/‎09/‎2023
OS build 22635.3646
Experience Windows Feature Experience Pack 1000.22700.1013.0

@utkubakir
Copy link
Contributor

Perfect, we will be pushing an update soon

@zaaakher
Copy link
Contributor Author

zaaakher commented Jun 1, 2024

Just tested it again with the official release v0.3.1 and this issue is resolved 👍 Thanks @HeavenVolkoff @utkubakir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants