Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"hamid" username hardcoded in workflow #21

Closed
luckman212 opened this issue Nov 4, 2018 · 5 comments
Closed

"hamid" username hardcoded in workflow #21

luckman212 opened this issue Nov 4, 2018 · 5 comments

Comments

@luckman212
Copy link

First: great workflow! Thanks for making this.

Little bug: when using the alt modifier to Reveal the bookmark on the pinboard.in website, the constructed URL is incorrect since it hardcodes /u:hamid/?query=...

Better would be to grab the username somewhere when user sets the API key, or if that's not possible, then require the user to set it via a workflow environment variable e.g.

image

and then

image

@spamwax
Copy link
Owner

spamwax commented Nov 5, 2018

ugh... thanks for reporting.
I'll fix it using one of the suggested methods and push an update soon.

spamwax added a commit that referenced this issue Nov 9, 2018
Search url to find the current bookmark on pinboard.in had 'hamid'
hard-coded as username. This commit grabs the user name during the
one-time auth token setup and replaces 'hamid' in info.plist with
the username captured.
spamwax added a commit that referenced this issue Nov 23, 2018
@matthauger
Copy link

FWIW, I think I'm still seeing this issue in v0.14.5. User 'hamid' hard-coded into the 'Open URL' action.

(Thank you for this AMAZING workflow, which I use dozens of time each day.)

@luckman212
Copy link
Author

I thought the same thing, but after refreshing my authorization token and closing and reopening the window, the username did eventually update.

@spamwax
Copy link
Owner

spamwax commented Jan 20, 2019

@matthauger did what luckman212 provide resolve your issue?

@matthauger
Copy link

matthauger commented Jan 23, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants