Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to log to a file #885

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

carlosm27
Copy link
Contributor

Description

This PR fixes #841

This PR adds the ability to create a log file.
This is an example of how to do it:

Screenshot 2024-07-07 230957

Screenshot 2024-07-07 230937

Copy link

vercel bot commented Jul 8, 2024

@carlosm27 is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

@carlosm27
Copy link
Contributor Author

Should we add the ability to add more configurations, like timestamps, levels, etc?

Copy link

codspeed-hq bot commented Jul 8, 2024

CodSpeed Performance Report

Merging #885 will not alter performance

Comparing carlosm27:log_file (f47c136) with main (0df6a9c)

Summary

✅ 110 untouched benchmarks

@carlosm27 carlosm27 changed the title feat : add ability to log to a file feat: add ability to log to a file Jul 8, 2024
@sansyrox
Copy link
Member

sansyrox commented Jul 9, 2024

Hey @carlosm27 👋

How would you use this new interface?

@carlosm27
Copy link
Contributor Author

Hey @carlosm27 👋

How would you use this new interface?

Hey @sansyrox. I would use it to create log files with timestamps, log level and with and add rotation policy.

What features are more appropiate for this interface?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an ability to log to a file
3 participants