Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a factory method to eliminate "results as hash" check #468

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

tenderlove
Copy link
Member

"Results as hash" should be set on the database, so we should only need to check it once when we first start the query. This patch pulls result set construction in to a factory method on the database object. Doing this eliminates a "translate to hash" check that is performed on every row fetch.

"Results as hash" should be set on the database, so we should only need
to check it once when we first start the query.  This patch pulls result
set construction in to a factory method on the database object.  Doing
this eliminates a "translate to hash" check that is performed on every
row fetch.
@fractaledmind
Copy link
Contributor

Love seeing these small details improvements. I'm learning a fair bit just from reading thru the recent PRs. Looking forward to v2.

@tenderlove tenderlove merged commit 21db633 into main Jan 10, 2024
@tenderlove tenderlove deleted the stop-checking-hash branch January 10, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants