New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type declaration to function #331

Merged

freekmurze merged 1 commit into spatie:main from BadJacky:feature/add-return-type-declaration

Mar 28, 2024

Contributor

BadJacky commented Mar 26, 2024

Title: Add return type declaration to the getFacadeAccessor method of the Skeleton class

Description:
In this PR, I added a return type declaration to the getFacadeAccessor method. This change can improve our code quality because:

It makes the code clearer and easier to read. By explicitly specifying the return type in the method signature, other developers can more easily understand the expected behavior of this method.
It can help us avoid type errors at runtime. If we try to return the wrong type, PHP will throw an error at compile time, not at runtime.

I look forward to your feedback!


Add return type declaration to function

c4d640f

freekmurze merged commit 3269952 into spatie:main

1 check passed

Member

freekmurze commented Mar 28, 2024

Thanks!

BadJacky deleted the feature/add-return-type-declaration branch

March 29, 2024 01:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment