Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MapFusion with NestedSDFGs #1312

Merged
merged 5 commits into from
Jul 13, 2023
Merged

Fix MapFusion with NestedSDFGs #1312

merged 5 commits into from
Jul 13, 2023

Conversation

alexnick83
Copy link
Contributor

This PR:

  • Adds a validation check for edges/Memlet paths and NestedSDFGs; if a NestedSDFG is src/dst of a Memlet path, then the dst/src must be an AccessNode.
  • Amends MapFusion to create new intermediate data, even when the access is Scalar, when connecting one or more NestedSDFGs.

@alexnick83 alexnick83 requested a review from phschaad July 12, 2023 15:56
phschaad
phschaad approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@phschaad phschaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alexnick83 alexnick83 merged commit 0a29384 into master Jul 13, 2023
9 checks passed
@alexnick83 alexnick83 deleted the fix-map-fusion-nested-sdfg-scalar-access branch July 13, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phschaad phschaad phschaad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexnick83 @phschaad