Added nan to the DaCe math namespace
#1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this was generating an error, because there was no object `nan` inside the `dace::math` namespace. This commit adds a `nan` object to the namespace, the implementation is based on `typeless_pi`.
There are two bugs. - On the CI `std::enable_if_t` was not there, so I changed it to the `typename std::enable_if`. - Also added operations regarding `typeless_nan` with itself (`typeless_pi` is missing them).
The same is also not used for `pi`.
philip-paul-mueller
force-pushed
the
nan_in_math
branch
from
112d070
to
8a9cb2c
Compare
tbennun
requested changes
Nov 30, 2023
dace/runtime/include/dace/nan.h
Outdated
| operator int() const = delete; | ||
| operator float() const | ||
| { | ||
| return std::nanf(""); |
There was a problem hiding this comment.
std::nan* use strto*, which will be slow. Please use numeric_limits' NaN: https://en.cppreference.com/w/cpp/types/numeric_limits/quiet_NaN
There was a problem hiding this comment.
Thanks for reminding me about that thing.
tbennun
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this was generating an error, because there was no object
naninside thedace::mathnamespace. This commit adds ananobject to the namespace, the implementation is based ontypeless_pi.