Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Property.from_string and Property.to_string #1529

Merged
merged 5 commits into from
Feb 25, 2024
Merged

Remove Property.from_string and Property.to_string #1529

merged 5 commits into from
Feb 25, 2024

Conversation

luca-patrignani
Copy link
Contributor

@luca-patrignani luca-patrignani commented Feb 20, 2024

This PR is to close issue #280.

@luca-patrignani luca-patrignani changed the title Remove Property.from_string Remove Property.from_string and Property.to_string Feb 20, 2024
@luca-patrignani luca-patrignani marked this pull request as ready for review February 20, 2024 23:13
@luca-patrignani
Copy link
Contributor Author

@tbennun can you review this?

@tbennun tbennun self-requested a review February 25, 2024 11:03
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbennun tbennun added this pull request to the merge queue Feb 25, 2024
Merged via the queue into spcl:master with commit 2614ef0 Feb 25, 2024
11 checks passed
@luca-patrignani luca-patrignani deleted the cleanup branch February 25, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants