-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Element Individuals to handle NONE and NOASSERTION scenarios for the 'to' property of Relationships #629
Conversation
…the 'to' property of Relationships
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pulling this together Sean. Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - The description of the NoAssertion captured all the cases I was looking for.
Thanks @sbarnum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some more explanation, especially that [Element1, NONE]
is not allowed. We should make that even more explicit so that validation also catches that.
There is also the case of a Relationship with from
=NOASSERTION, relationshipType
="ancestorOf", and to
=Element1. This should also be explained or should be disallowed. Same for NONE.
Co-authored-by: Maximilian Huber <[email protected]>
I disagree that this is the right direction. I think a to relationship towards an empty list, together with relationship completeness, is a better way to express that information. |
Discussion is we should document from migration guide, how to go this for 3.0. Concern is this with completeness is going to cause more confusion than it resolves. Let's document it, and then decide which PR to apply. ( Documenting Empty list is ok with completeness indicator.. vs. adding this in again) |
Decided to move this to post RC2 and go with the existing solution using the |
Co-authored-by: Maximilian Huber <[email protected]>
From tech call on 2 April 2024: agreed to rename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per tech call on 2 April 2024 -
704fe7a
to
dd15fb3
Compare
@maxhbr - I believe this matches our discussion on the tech call - please re-review |
Addresses #527