Add cwe as ExternalRefType #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puerco
requested changes
Apr 10, 2024
There was a problem hiding this comment.
I think this is not correct.
A CWE string is not an identifier like a CVE number is, for example. A vulnerability can have as its root cause more than one CWE.
The CWE strings are a reference to a catalog of vulnerability categories. As per your definitions in #710, I think an ExternalRef fits better.
Per discussion in the April 10 Security call, this commit adds cwe (common weakness enumeration) as an ExternalRefType. Closes spdx/spdx-spec#102 Signed-off-by: Rose Judge <[email protected]>
|
Thanks @puerco! PR updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in the April 10 Security call, this commit adds cwe (common weakness enumeration) as an ExternalIdentifierType.
Closes spdx/spdx-spec#102