Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples validation to v3.0.1 #1111

Merged
merged 10 commits into from
Sep 10, 2024
Merged

Update examples validation to v3.0.1 #1111

merged 10 commits into from
Sep 10, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Sep 6, 2024 •
edited
Loading

  • Update relevant URLs to 3.0.1 ones
    • Also put all of them in one place, so it will be a bit more convenient to update next time
  • Consolidated code to use the existing check_schema and check_model functions

Note: This will not working until the first part of #1108 (the 3.0.1 part) got resolved
(setting up https://spdx.org/rdf/3.0.1/spdx-model.ttl, etc)

3.0.1 part of #1108 is already applied. These URLs are ready:

After reviews, we can merge this.

This PR will resolve #1049

@bact
Update check-examples.sh validator to v3.0.1
cb2b19b 
- Also consolidated code to use the existing check_schema and check_model functions
- Update relevant URLs to 3.0.1 ones

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Merge branch 'spdx:development/v3.0.1' into v3.0.1-examples-validation
85bf8e3
@bact
Fix directory
63e919a 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact added publishing ci Dev workflow and repo management labels Sep 6, 2024
@bact bact added this to the 3.0.1 milestone Sep 6, 2024
@bact bact requested review from zvr, goneall and maxhbr September 6, 2024 14:03
@bact
Update check-examples.sh
281f3b0 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Copy link
Collaborator Author

bact commented Sep 6, 2024

@JPEWdev does this look ok? Thank you for your help.

@bact bact mentioned this pull request Sep 7, 2024
Open
@bact
Update check-jsonschema version to 0.29.2
0d9a0ae 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Copy link
Collaborator Author

bact commented Sep 7, 2024 •
edited
Loading

All necessary 3.0.1 URLs are ready. We can now go ahead with this PR.

goneall
goneall approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bact bact added the blocker Issue which is blocking progress in the spec development label Sep 9, 2024
kestewart
kestewart approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed on call, and no issues from Bob on merging this.
Looks like we need this merged for validation to work, so prioritizing getting this.

maxhbr
maxhbr approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, up to minor comments

bin/check-examples.sh Outdated Show resolved Hide resolved
bin/check-examples.sh Outdated Show resolved Hide resolved
bin/check-examples.sh
done
fi

TEMP=$(mktemp -d)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temporary directory is not cleaned up

bact and others added 3 commits September 10, 2024 17:23
@bact @maxhbr
Update bin/check-examples.sh
03a1cb7 
Co-authored-by: Maximilian Huber <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact @maxhbr
Update bin/check-examples.sh
9447008 
Co-authored-by: Maximilian Huber <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Update check-examples.sh
a74fb58 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
maxhbr
maxhbr approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my suggestions were incomplete

bin/check-examples.sh Outdated Show resolved Hide resolved
bin/check-examples.sh Outdated Show resolved Hide resolved
bin/check-examples.sh Outdated Show resolved Hide resolved
@bact bact merged commit ce2a9a5 into spdx:development/v3.0.1 Sep 10, 2024
2 checks passed
@bact bact deleted the v3.0.1-examples-validation branch September 10, 2024 16:28
@bact
Copy link
Collaborator Author

bact commented Sep 10, 2024

Thank you @maxhbr, I also use your suggestions to update the similar validation script in spdx/using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneall goneall goneall approved these changes

@maxhbr maxhbr maxhbr approved these changes

@kestewart kestewart kestewart approved these changes

@zvr zvr Awaiting requested review from zvr

Assignees
No one assigned
Labels
blocker Issue which is blocking progress in the spec development ci Dev workflow and repo management publishing
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

Update bin/check-examples.sh to v3.0.1
4 participants
@bact @goneall @maxhbr @kestewart