Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alacritty to the supported terminals in AnsiDetector #1211

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

MaxAtoms
Copy link
Contributor

@MaxAtoms MaxAtoms commented Apr 3, 2023

As far as I can tell, Alacritty works without issues.
In the past, I had problems with Live Display, but these seem to be fixed now.

In the following video, I demonstrate the usage of the selection prompt and Live Display.

spectre-console-alacritty.mp4

Let me know if there is anything else that I should verify.

@MaxAtoms
Copy link
Contributor Author

MaxAtoms commented Apr 3, 2023

@microsoft-github-policy-service agree

Copy link
Contributor

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patriksvensson patriksvensson merged commit d64d3ec into spectreconsole:main Apr 3, 2023
@patriksvensson
Copy link
Contributor

Merged! Thank you for your contribution. Much appreciated! 👍

@MaxAtoms
Copy link
Contributor Author

MaxAtoms commented Apr 3, 2023

Well, that was fast. You're welcome. Thank you for all the much harder work you've put into Spectre.Console over the last years :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants