Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work done to allow user to update table cell. #546

Merged
merged 2 commits into from
Sep 27, 2021

Conversation

RollsChris
Copy link
Contributor

Issue URL: #544

Hope everything is up to standard.

let me know of any changes.

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2021

CLA assistant check
All committers have signed the CLA.

@patriksvensson
Copy link
Contributor

@RedEyedDog Could you rebase this against upstream main so we can see that all checks pass?

@RollsChris
Copy link
Contributor Author

@RedEyedDog Could you rebase this against upstream main so we can see that all checks pass?

I'm not sure what you mean sorry is it out of date with master?

@patriksvensson
Copy link
Contributor

patriksvensson commented Sep 27, 2021

@RedEyedDog Yes exactly. Sync your main branch locally, switch to updatecell branch and write git rebase main followed by a git push --force-with-lease.

@RollsChris
Copy link
Contributor Author

@RedEyedDog Yes exactly. Sync your main branch locally, switch to updatecell branch and write git rebase main followed by a git push --force-with-lease.

Hey its telling me I am up to date ?

@patriksvensson
Copy link
Contributor

@RedEyedDog It is not, so make sure that your fork is up to date before doing the rebase, and make sure you've done a git pull on the main branch of your fork before as well.

image

@RollsChris
Copy link
Contributor Author

@patriksvensson ok I have done that. Sorry this will be my first contribution to an open source project. POP MY CHERRY ;)

@patriksvensson
Copy link
Contributor

@RedEyedDog Great! Running CI again.

Welcome to the world of OSS btw! 🎉

Copy link
Contributor

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (looks good to me) 👍

@RollsChris
Copy link
Contributor Author

Thanks for all your help :) till next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants