Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for styling and aligning paths #746

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Add support for styling and aligning paths #746

merged 2 commits into from
Feb 23, 2022

Conversation

patriksvensson
Copy link
Contributor

No description provided.

@patriksvensson patriksvensson requested a review from a team February 22, 2022 20:11
phil-scott-78
phil-scott-78 reviewed Feb 23, 2022
View reviewed changes
Copy link
Contributor

@phil-scott-78 phil-scott-78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but I noticed the example project is in the Live namespace rather than the Paths namespace.

While not a big deal for the PR, it does make the docs get confused when looking for unique symbols throughout the solution.

@patriksvensson
Copy link
Contributor Author

@phil-scott-78 Good catch. I've updated the PR.

@phil-scott-78 phil-scott-78 merged commit eb4a7d3 into spectreconsole:main Feb 23, 2022
@patriksvensson patriksvensson deleted the feature/paths-2 branch February 23, 2022 15:52
This was referenced Mar 27, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@renovate renovate bot mentioned this pull request Apr 3, 2022
Merged
1 task
@renovate renovate bot mentioned this pull request Apr 27, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-scott-78 phil-scott-78 phil-scott-78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patriksvensson @phil-scott-78