Add flag --skipmerklecheck #4957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --skipmerklecheck optional flag makes Electrum tolerate invalid merkle proofs from the server. This is useful for building Electrum servers that need a minimum amount of storage, though of course users should only enable it if they completely trust the connected server.
|
Could I get a concept ACK ? |
|
Tested this now; looks okay. Note that when this option is enabled, the wallet file will get modified as if the present transactions have been SPV verified (these transactions will not be rechecked even if the user disables the option and connects to different servers). The assumption is that the user only uses this option when connected to a server they fully trust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--skipmerklecheckoptional flag makes Electrum tolerate invalid merkle proofs from the server. This is useful for building Electrum servers that need a minimum amount of storage, though of course users should only enable it if they completely trust the connected server.This is primarily motivated so that Electrum Personal Server can be compatible with pruning. Users who have a pruned full node would enable
--skipmerklecheck. Also it would make it much easier to create a "no history" mode where the rpc callscantxoutset(chris-belcher/electrum-personal-server#27) is used to find a wallet balance without needing a long rescan.The way this works is based on an IRC conversation with ghost43 who suggested this method, saying it's a little bit hacky but is easy to test and maintain, and is preferable to modifying the code in 10 different places for something that wouldn't be tested very often.