-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inner map on structs are not considered when unmarshalling with viper_bind_struct tag #1800
Comments
👋 Thanks for reporting! A maintainer will take a look at your issue shortly. 👀 In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues. ⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9 📣 If you've already given us your feedback, you can still help by spreading the news, https://twitter.com/sagikazarmark/status/1306904078967074816 Thank you! ❤️ |
Is this really the Viper version you are using? It's pretty old. I just ran your test locally, and it passed. The reason for that is you read the JSON configuration first, which will populate Viper with those keys. Bind struct is not in play here. If you remove the I'm not quite sure what the right solution is in this case. Maybe some sort of glob matching to allow manually bind env vars without having to specify the map keys? In any case, the above test should work if you have those values defined in a config file. |
Preflight Checklist
Viper Version
1.12.2
Go Version
1.22.1
Config Source
Environment variables, Files
Format
JSON
Repl.it link
No response
Code reproducing the issue
Expected Behavior
It should be possible to bind map values through environment variables.
Actual Behavior
The environment variable is not considered.
Steps To Reproduce
Execute the code I provided.
Additional Information
When coding this, I thought it would be hard for Viper to consider this complex structure. How will the code know the map's key from the environment variable? Maybe it should have a specific separator for map keys? Like
EXAMPLE_MAP_DATA__FIRST__ENABLED
instead ofEXAMPLE_MAP_DATA_FIRST_ENABLED
? I don't know if I'm doing something wrong here.I didn't manage to create a new map key from an environment variable. I think the documentation for environment variables when using maps, slices, etc is kind of outdated and must be updated. I'm doing trial-error for several minutes trying to make this work and I don't have any idea if I'm in the right direction.
The text was updated successfully, but these errors were encountered: