Correctly synchronize root_doc and master_doc
#12417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12416.
Setting
root_docshould also affect the value ofmaster_doc. The patch is the simplest one that I could think of. The alternative is to also patchsphinxcontrib-devhelpbut I'm not sure if Sphinx 5.0 (which is the minimum for that extension) already handles the alias correctly.@AA-Turner Can you review this one or suggest something else? (or merge sphinx-doc/sphinxcontrib-devhelp#12).
If there are other extensions suffering from that issue, please let me know.