Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent can be set rp_filter to 0 for the each node #3913

Merged
merged 1 commit into from
Aug 21, 2024
Merged

agent can be set rp_filter to 0 for the each node #3913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/coordinator/cmd/command_add.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,14 +256,14 @@ func CmdAdd(args *skel.CmdArgs) (err error) {

if ipFamily != netlink.FAMILY_V4 {
// ensure ipv6 is enable
if err := sysctl.EnableIpv6Sysctl(c.netns); err != nil {
if err := sysctl.EnableIpv6Sysctl(c.netns, 0); err != nil {
logger.Error(err.Error())
return err
}
}

if conf.RPFilter != -1 {
if err = sysctl.SysctlRPFilter(c.netns, conf.RPFilter); err != nil {
if err = sysctl.SetSysctlRPFilter(c.netns, conf.RPFilter); err != nil {
logger.Error(err.Error())
return err
}
Expand Down
1 change: 1 addition & 0 deletions docs/reference/spiderpool-agent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ To optimize the kernel network configuration of a node, spiderpool-agent will by
| net.ipv4.conf.all.arp_notify | 1 | Generate gratuitous arp requests when device is brought up or hardware address changes.|
| net.ipv4.conf.all.forwarding | 1 | enable ipv4 forwarding |
| net.ipv6.conf.all.forwarding | 1 | enable ipv6 forwarding |
| net.ipv4.conf.all.rp_filter | 0 | no source validation for the each incoming packet |

Note: Some kernel parameters can only be set in certain kernel versions, so we will ignore the "kernel parameter does not exist" error when configure the kernel parameters. Example: `net.ipv6.neigh.default.gc_thresh3`.

Expand Down
76 changes: 17 additions & 59 deletions pkg/networking/sysctl/sysctl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ import (
"github.com/containernetworking/plugins/pkg/utils/sysctl"
)

var (
SysctlRPFilter = "net.ipv4.conf.all.rp_filter"
SysctlEnableIPv6 = "net.ipv6.conf.all.disable_ipv6"
)

// DefaultSysctlConfig is the default sysctl config for the node
var DefaultSysctlConfig = []struct {
Name string
Expand Down Expand Up @@ -52,74 +57,27 @@ var DefaultSysctlConfig = []struct {
Value: "1",
IsIPv6: true,
},
{
Name: "net.ipv4.conf.all.rp_filter",
Value: "0",
IsIPv4: true,
IsIPv6: true,
},
}

// SysctlRPFilter set rp_filter value for host netns and specify netns
func SysctlRPFilter(netns ns.NetNS, value int32) error {
var err error
if err = setRPFilter(value); err != nil {
return fmt.Errorf("failed to set host rp_filter : %v", err)
}
func SetSysctlRPFilter(netns ns.NetNS, value int32) error {
// set pod rp_filter
err = netns.Do(func(_ ns.NetNS) error {
if err := setRPFilter(value); err != nil {
return fmt.Errorf("failed to set rp_filter in pod : %v", err)
}
return nil
return netns.Do(func(_ ns.NetNS) error {
return SetSysctl(SysctlRPFilter, fmt.Sprintf("%v", value))
})
if err != nil {
return err
}
return nil
}

// setRPFilter set rp_filter
func setRPFilter(v int32) error {
dirs, err := os.ReadDir("/proc/sys/net/ipv4/conf")
if err != nil {
return err
}
for _, dir := range dirs {
name := fmt.Sprintf("/net/ipv4/conf/%s/rp_filter", dir.Name())
value, err := sysctl.Sysctl(name)
if err != nil {
continue
}
if value == fmt.Sprintf("%d", v) {
continue
}
if _, e := sysctl.Sysctl(name, fmt.Sprintf("%d", v)); e != nil {
return e
}
}
return nil
}

// EnableIpv6Sysctl enable ipv6 for specify netns
func EnableIpv6Sysctl(netns ns.NetNS) error {
err := netns.Do(func(_ ns.NetNS) error {
dirs, err := os.ReadDir("/proc/sys/net/ipv6/conf")
if err != nil {
return err
}

for _, dir := range dirs {
// Read current sysctl value
name := fmt.Sprintf("/net/ipv6/conf/%s/disable_ipv6", dir.Name())
value, err := sysctl.Sysctl(name)
if err != nil {
return fmt.Errorf("failed to read current sysctl %+v value: %v", name, err)
}
// make sure value=0
if value != "0" {
if _, err = sysctl.Sysctl(name, "0"); err != nil {
return fmt.Errorf("failed to read current sysctl %+v value: %v ", name, err)
}
}
}
return nil
func EnableIpv6Sysctl(netns ns.NetNS, value int32) error {
return netns.Do(func(_ ns.NetNS) error {
return SetSysctl(SysctlEnableIPv6, fmt.Sprintf("%v", value))
})
return err
}

func SetSysctl(sysConfig string, value string) error {
Expand Down
Loading