Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token renewal test #4330

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Conversation

hiyosi
Copy link
Contributor

@hiyosi hiyosi commented Jul 10, 2023

Pull Request check list

  • Commit conforms to CONTRIBUTING.md?
  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality

Integration test for the UpstreamAuthority vault plugin.

Description of change

Added a test to verify that the Vault Token is renewed.
Before this, token renewal had to be checked by actually running the system.

Which issue this PR fixes

Signed-off-by: Tomoya Usami <[email protected]>
Copy link
Member

@evan2645 evan2645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @hiyosi!

@evan2645 evan2645 merged commit a367d5b into spiffe:main Jul 18, 2023
21 checks passed
@evan2645 evan2645 added this to the 1.7.2 milestone Jul 18, 2023
@hiyosi hiyosi deleted the test-vault-token-renewal branch July 18, 2023 23:11
Neniel pushed a commit to Neniel/spire that referenced this pull request Jul 21, 2023
Signed-off-by: Tomoya Usami <[email protected]>
Co-authored-by: Evan Gilman <[email protected]>
Signed-off-by: Neniel <[email protected]>
Neniel pushed a commit to Neniel/spire that referenced this pull request Aug 24, 2023
Signed-off-by: Tomoya Usami <[email protected]>
Co-authored-by: Evan Gilman <[email protected]>
Signed-off-by: Neniel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants