Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spinalcordtoolbox dependency for installation #18

Open
NathanMolinier opened this issue Jun 5, 2023 · 4 comments
Open

Spinalcordtoolbox dependency for installation #18

NathanMolinier opened this issue Jun 5, 2023 · 4 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@NathanMolinier
Copy link
Collaborator

NathanMolinier commented Jun 5, 2023 •
edited
Loading

Description

The code depends currently on the spinalcordtoolbox due to the import of the object Image to manipulate 3D niftii images.

Should we replace this import to simplify installation ? (see src/dlh/utils/data2array.py)
@NathanMolinier NathanMolinier added enhancement New feature or request question Further information is requested labels Jun 5, 2023
@jcohenadad
Copy link
Member

I would recommend using the nibabel library.

@NathanMolinier
Copy link
Collaborator Author

I also was using the spinalcordtoolbox (SCT) to use the orientation manipulations functions such as the method change_orientation in Image. Therefore, if remove SCT and use nibabel, I will have to rewrite those functions locally.

@jcohenadad
Copy link
Member

maybe it’s not a big deal to keep SCT dependence

@NathanMolinier
Copy link
Collaborator Author

It also make sense because the repository is inside the spinalcordtoolbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcohenadad @NathanMolinier