Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add processed images in the derivatives folder #156

Closed
sandrinebedard opened this issue Feb 8, 2024 · 5 comments · Fixed by #159
Closed

Add processed images in the derivatives folder #156

sandrinebedard opened this issue Feb 8, 2024 · 5 comments · Fixed by #159
Assignees

Comments

@sandrinebedard
Copy link
Member

sandrinebedard commented Feb 8, 2024

Description

Since the labels in the derivatives were generated from preprocessed images (reorientation, resampling, etc.), to avoide confusion and issues such as #153 and repeating these steps, we propose to include the preprocessed images inside the derivatives folder in a sub-folder.

Suggestion

  • Add the preprocessed images in : derivatives/processed_data (we can discuss on better names)
  • Include in the README of derivatives/processed_data a link to a release of the dataset and preprocessing script used to create these images

Tasks:

  • add dataset description
  • add readme (and link to processing script)
  • add suffix space-other
  • add suffix description space-other in all json
  • create json sidecar for dwi rec-average

Relevant issues:

#144
#153

@sandrinebedard sandrinebedard self-assigned this Feb 8, 2024
@sandrinebedard
Copy link
Member Author

@NathanMolinier
Copy link
Contributor

Agree with this proposal ! Also, from a more technical standpoint, to follow our conventions, the entity space-other should be added to the filename as well as a JSON sidecar file. Examples are shown here.

@sandrinebedard
Copy link
Member Author

Agree with this proposal ! Also, from a more technical standpoint, to follow our conventions, the entity space-other should be added to the filename as well as a JSON sidecar file. Examples are shown here.

would we also add it in all the labels too?

@NathanMolinier
Copy link
Contributor

Yes we should do that also

@jcohenadad
Copy link
Member

My two cents:

  • agreed with adding space-other to minimize confusion about the labels' native space
  • given that the data are only resampled/reoriented maybe we should call it data_preprocessed instead?
  • i would add the software used to preprocess the data (as done in BIDS Apps), eg: data_preprocessed_sct6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants