Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload PAM50 registered labels from Yehuda Warszawer #160

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mguaypaq
Copy link
Member

These are the PAM50 registered labels supplied by @yw7 in #155.

I split the upload into two commits:

  1. Some of the files are completely new, so there's no conflict.
  2. Some of the files would overwrite existing files, by Etienne Bergeron, @valosekj, @NathanMolinier, Olivier Morinlupien, Paul Bautin, @sandrinebedard, Yassine El Bouchaibi. Which ones do we want to keep?

And some questions for Yehuda:

  • The zip file contained a text file called derivatives/errors.txt, which contains the single line of text, sub-pavia04_T1w_PAM50_seg.nii.gz. What does this mean?
  • It seems like there are a lot of .nii.gz files without a corresponding JSON sidecar.
  • Some of the contributed files have a JSON sidecar saying they're from Charley Gros, why is that?

Contributed by Yehuda Warszawer
Contributed by Yehuda Warszawer
@sandrinebedard
Copy link
Member

This PR refractors all the naming in the data-multi-subject dataset:

#159

I am just missing updtaing and tested the related scripts, maybe we should address it before this PR, and afterwards we can update all the naming convention to be in sync

@mguaypaq
Copy link
Member Author

I'm happy to wait until #159 is merged before tackling this upload. I mainly wanted to put it up on github as a PR as quickly as possible.

@yw7
Copy link

yw7 commented Feb 27, 2024

  • The zip file contained a text file called derivatives/errors.txt, which contains the single line of text, sub-pavia04_T1w_PAM50_seg.nii.gz. What does this mean?

This is file in which the registered segmentation from PAM50 was wrong:

image

  • It seems like there are a lot of .nii.gz files without a corresponding JSON sidecar.
  • Some of the contributed files have a JSON sidecar saying they're from Charley Gros, why is that?

I've created the missing _PAM50_seg jsons sidecars here: data-multi-subject_PAM50_seg_sidecars_jsons.zip

Regardingthe _seg files actually only the ones with "Author": "Yehuda Warszawer" are new (when double checked, I notice I included also the original unchenged files with the original sidecars json ) Will it help If Ill recreate zip file containing only the new files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants