Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add segmentations from William Sirois #172

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

mguaypaq
Copy link
Member

@mguaypaq mguaypaq commented Aug 6, 2024

These are the files provided by William Sirois at the end of his GBM3100 internship. Todo:

  • Figure out which derivatives/ subfolder they should go into.
  • Rename the files according to BIDS.
  • Add JSON sidecars.

While uploading the files, I noticed that most of them are new, but a few of them are exact duplicates of already existing files in the repository.

@sandrinebedard
Copy link
Member

I added to the branch the spinal cord canal seg under derivatives/labels, I am not sure that it worked, @mguaypaq can you check?

@mguaypaq
Copy link
Member Author

It looks like this is what happened:

  • 1 of the 188 images from William Sirois (sub-barcelona02_011) got replaced by a new image from Sandrine (sub-barcelona02_space-other_T2w_label-canal_seg.nii.gz).
  • 4 of the 188 images from William Sirois were exact copies of existing canal_seg files under derivatives/labels/.
  • 6 of the 188 images from William Sirois replaced existing canal_seg files under derivatives/labels/.
  • The remaining 177 of 188 images from William Sirois are new canal_seg files under derivatives/labels/.

But:

  • There are also 80 new sub-*_T2w_label-discs_dlabel.nii.gz images from Sandrine under derivatives/labels/.

@sandrinebedard is this what you wanted?

@sandrinebedard
Copy link
Member

sandrinebedard commented Aug 14, 2024

But:

  • There are also 80 new sub-*_T2w_label-discs_dlabel.nii.gz images from Sandrine under derivatives/labels/.

@sandrinebedard is this what you wanted?

Nope hahaha, just realized a script I was running was modifying the files... sorry, we should remove those changes

@mguaypaq
Copy link
Member Author

Ok, I can remove the extra modifications. Do we also need to create and/or update any JSON sidecars with the provenance of the data?

@sandrinebedard
Copy link
Member

Abel just created them yesterday, I will push them today!

@mguaypaq
Copy link
Member Author

I don't think these are the right JSON sidecars; they describe the 267 images mentioned at the end of ivadomed/model-canal-seg#7, but not the 188 images mentioned at the start (which are the ones in this PR). We probably need at least 4 different JSON files:

  • The 4 images that were already in this dataset before the PR have existing JSON sidecars, so we should use them.
  • The 1 image that was modified in 5c22e3d (instead of being just moved) needs an explanation of what was done to modify it.
  • The 6 images that replace existing canal segs, we should check whether they are manual corrections, or the result of an earlier model, or what.
  • The 177 other images, we should figure out how they were produced.

That's if we want the 188 images used as ground truth for the training. Alternatively, if we want the 267 images produced by the final model, we could upload them instead? Or, if we're not sure of the origin, we should say that in the JSON files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants