Improve function mutableSignature() in MutableStaticFields detector #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of `mutableSignature()` is a prototype. This patch contains an implementation which uses several heuristics to attempt determining whether a class is mutable. Furthermore we moved this function to the `util` package. Change-Id: Ie8efec6b1f4eb330d8c5b2da30036e3703056a9e
ThrawnCA
approved these changes
May 3, 2021
1 task
gtoison
added a commit
to gtoison/spotbugs
that referenced
this pull request
Aug 26, 2023
In spotbugs#1533 the MutableStaticFields was modified to warn for classes deemed to be mutable. Previously only arrays and a few (HashTable, Date, TimeStamp) were considered mutable. However the description for MS_EXPOSE_REP kept only mentioning arrays
1 task
hazendaz
added a commit
that referenced
this pull request
Aug 26, 2023
… just arrays (#2535) * fix: updated MS_EXPOSE_REP description In #1533 the MutableStaticFields was modified to warn for classes deemed to be mutable. Previously only arrays and a few (HashTable, Date, TimeStamp) were considered mutable. However the description for MS_EXPOSE_REP kept only mentioning arrays * updated the changelog * Update messages_fr.xml * Update messages_fr.xml oops that was french, fixing back --------- Co-authored-by: Jeremy Landis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
mutableSignature()is a prototype. Thispatch contains an implementation which uses several heuristics to
attempt determining whether a class is mutable. Furthermore we moved
this function to the
utilpackage.Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code