Fixes the SpringVaultEnvironmentRepository issue with composite profile #2594
+121
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanjbaxter
requested changes
Oct 17, 2024
Oh, you are so fast. I was just preparing the PR description. Let me see If there is a way to fix it without changing the method signature. |
Signed-off-by: kvmw <[email protected]>
ryanjbaxter
reviewed
Oct 17, 2024
...framework/cloud/config/server/environment/vault/SpringVaultEnvironmentRepositoryFactory.java
Show resolved
Hide resolved
ryanjbaxter
approved these changes
Oct 17, 2024
|
Also can you make this PR against the 4.1.x branch |
|
closing this in favour of #2595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2592
So the SpringVaultEnvironmentRepositoryFactory::build was being called with the correct instance of
VaultEnvironmentPropertiesbut it was not using those properties for creation of VaultTemplate. Instead it was using the injected instance ofSpringVaultClientConfigurationwhich had only the vault properties provided underspring.cloud.config.server.vault.