Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require token-based authentication #104

Closed
wilkinsona opened this issue Mar 14, 2024 · 1 comment
Closed

Require token-based authentication #104

wilkinsona opened this issue Mar 14, 2024 · 1 comment

Comments

@wilkinsona
Copy link
Contributor

When there's a token configured, it's used as the value of the password:

When deciding whether to configure authentication, there has to be a username:

if (StringUtils.hasLength(username)) {
builder = builder.basicAuthentication(username, password);
}

With token-based authentication, a username isn't necessary. Instead, we should present the token as part of an Authentication: Bearer header.

@wilkinsona wilkinsona added this to the 0.0.10 milestone Mar 14, 2024
@wilkinsona
Copy link
Contributor Author

GitHub no longer supports username and password based authentication. The password has to be a token, and when it is, the username is ignored. We should adapt to this by dropping support for github.username and github.password and requiring github.token instead.

@wilkinsona wilkinsona changed the title Support token-based authentication without a username Require token-based authentication Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant