Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clearer that WebSocket dependency is Servlet-based #1089

Closed
mhalbritter opened this issue Jan 16, 2023 · 0 comments
Closed

Make it clearer that WebSocket dependency is Servlet-based #1089

mhalbritter opened this issue Jan 16, 2023 · 0 comments

Comments

@mhalbritter
Copy link
Contributor

mhalbritter commented Jan 16, 2023

Right now, the WebSocket entry doesn't make it clear that it only works with Spring MVC. See spring-projects/spring-boot#32493 for example.

Would be great if the description could be changed to make it clear that this is for Spring MVC and is not needed for WebFlux websocket applications.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 16, 2023
@wilkinsona wilkinsona changed the title Include MVC in WebSocket entry description Make it clearer that WebSocket dependency is Servlet-based Jan 17, 2023
@wilkinsona wilkinsona added type: enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants