-
Notifications
You must be signed in to change notification settings - Fork 40.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Jetty / Netty / Apache HttpClient checks for WebClient #33474
Labels
status: superseded
An issue that has been superseded by another
Comments
I wonder if we should consider this a bug? Looking at the code, the checks are preventing the auto-configuration of a |
wilkinsona
added
the
for: team-attention
An issue we'd like other members of the team to review
label
Jan 3, 2023
Closing in favor of #33640. |
scottfrederick
removed
type: enhancement
A general enhancement
for: team-attention
An issue we'd like other members of the team to review
labels
Jan 3, 2023
scottfrederick
added
the
status: superseded
An issue that has been superseded by another
label
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With spring-projects/spring-framework#29644 the
WebClient
doesn't need external dependencies anymore. If no netty / jetty / Apache HttpClient is found, it falls back to theJdkClientHttpConnector
which is baked into the JDK.At least in
org.springframework.boot.test.web.reactive.server.WebTestClientContextCustomizerFactory
we check for the presence of netty / jetty / apache httpclient. This check can be removed, and maybe such checks are somewhere else in the codebase.The text was updated successfully, but these errors were encountered: