Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from spring.factories for auto-configuration imports #29745

Closed
wants to merge 34 commits into from

Conversation

mhalbritter
Copy link
Contributor

@mhalbritter mhalbritter commented Feb 11, 2022

See #29698

The most important changes are:

Task list

  • Design and document a file format that can replace spring.factories for auto-configuration.
  • Update the existing import to use both spring.factories and the new entries.
  • Introduce a new @AutoConfiguration annotation which is meta-annotated with @Configuration. The new annotation will default proxyBeanMethods to false.
  • Document the changes in the reference docs
  • provide a wiki migration guide
  • Update documentation tooling in buildSrc to read the new file
  • Check with existing IDE and tool vendors to ensure the new format doesn't cause issues

The following nice-to-have tasks have been identified:

  • Develop a migration tool to convert our existing codebase (a tool will be valuable for other project, but we might also be able to use sed)
  • Update our annotation processor so the the new auto-configuration file can be auto-generated

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 11, 2022
@mhalbritter
Copy link
Contributor Author

I splitted the commits into different issues and commited them directly to 2.7.x branch. This PR is obsolete.

@mhalbritter mhalbritter added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 17, 2022
@mhalbritter mhalbritter deleted the gh-29698 branch February 23, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants