Skip to content

Commit

Permalink
Introspect pre-registered singletons in preDetermineBeanTypes as well
Browse files Browse the repository at this point in the history
Closes gh-33668
  • Loading branch information
jhoeller committed Oct 8, 2024
1 parent c4b6a02 commit f590511
Showing 1 changed file with 22 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -425,25 +425,37 @@ public void refreshForAotProcessing(RuntimeHints runtimeHints) {
* @see SmartInstantiationAwareBeanPostProcessor#determineBeanType
*/
private void preDetermineBeanTypes(RuntimeHints runtimeHints) {
List<String> singletons = new ArrayList<>();
List<String> lazyBeans = new ArrayList<>();

// First round: pre-registered singleton instances, if any.
for (String beanName : this.beanFactory.getSingletonNames()) {
Class<?> beanType = this.beanFactory.getType(beanName);
if (beanType != null) {
ClassHintUtils.registerProxyIfNecessary(beanType, runtimeHints);
}
singletons.add(beanName);
}

List<SmartInstantiationAwareBeanPostProcessor> bpps =
PostProcessorRegistrationDelegate.loadBeanPostProcessors(
this.beanFactory, SmartInstantiationAwareBeanPostProcessor.class);

List<String> lazyBeans = new ArrayList<>();

// First round: non-lazy singleton beans in definition order,
// Second round: non-lazy singleton beans in definition order,
// matching preInstantiateSingletons.
for (String beanName : this.beanFactory.getBeanDefinitionNames()) {
BeanDefinition bd = getBeanDefinition(beanName);
if (bd.isSingleton() && !bd.isLazyInit()) {
preDetermineBeanType(beanName, bpps, runtimeHints);
}
else {
lazyBeans.add(beanName);
if (!singletons.contains(beanName)) {
BeanDefinition bd = getBeanDefinition(beanName);
if (bd.isSingleton() && !bd.isLazyInit()) {
preDetermineBeanType(beanName, bpps, runtimeHints);
}
else {
lazyBeans.add(beanName);
}
}
}

// Second round: lazy singleton beans and scoped beans.
// Third round: lazy singleton beans and scoped beans.
for (String beanName : lazyBeans) {
preDetermineBeanType(beanName, bpps, runtimeHints);
}
Expand Down

0 comments on commit f590511

Please sign in to comment.