Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently support CompletionStage/CompletableFuture in ReactiveAdapterRegistry #23011

Closed
jhoeller opened this issue May 21, 2019 · 0 comments
Closed

Consistently support CompletionStage/CompletableFuture in ReactiveAdapterRegistry #23011

jhoeller opened this issue May 21, 2019 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
5.2 M3

Comments

@jhoeller
Copy link
Contributor

Along the lines of #19823 in the 4.3.x line, we should revise ReactiveAdapterRegistry towards CompletionStage support, considering all implementations of that interface as adaptable (instead of just CompletableFuture). This makes reactive return types for WebFlux consistent with MVC/messaging handler methods, most importantly allowing return type declarations to use the CompletionStage interface even if they effectively return CompletableFuture instances at runtime.
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels May 21, 2019
@jhoeller jhoeller added this to the 5.2 M3 milestone May 21, 2019
@jhoeller jhoeller self-assigned this May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 M3
Development

No branches or pull requests
1 participant
@jhoeller