Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Printers and Parsers to be registered individually to FormatterRegistry #23110

Closed
philwebb opened this issue Jun 11, 2019 · 7 comments
Closed
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@philwebb
Copy link
Member

Currently FormatterRegistry has a registerFormatter method but no registerPrinter or registerParser methods. This makes this Spring Boot pull-request a little more verbose than it should be because it's copied the private PrinterConverter and ParserConverter classes.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 11, 2019
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 11, 2019
@sbrannen
Copy link
Member

SGTM.

@philwebb, do you want to tackle this one yourself in time for 5.2 RC1? Or shall one of us take it over?

@sbrannen sbrannen added this to the 5.2 RC1 milestone Jun 11, 2019
@philwebb philwebb self-assigned this Jun 11, 2019
@philwebb
Copy link
Member Author

Sorry, forgot to assign it. Working on it currently.

@sbrannen sbrannen modified the milestones: 5.2 RC1, 5.2 M3 Jun 11, 2019
@renjie-rm
Copy link

Does the print method of formatter need to inject the bean itself and then call the formatting method? @philwebb

@renjie-rm
Copy link

It cannot be called through Spring like parse?

@renjie-rm
Copy link

Looking forward to your reply. Thank you!@philwebb

@philwebb
Copy link
Member Author

philwebb commented Sep 1, 2021

@renjie-rm I'm not sure I understand your question. Perhaps you could rephrase it and ask on stackoverflow.com. Feel free to paste a link to the question back here.

@renjie-rm
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants