GH-1119: do not invoke reconcile operation when only computing docume…

…nt symbols
spring-projects · Oct 20, 2023 · 31e3667 · 31e3667
1 parent 2977081
commit 31e3667
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/...erver/src/main/java/org/springframework/ide/vscode/boot/java/utils/SpringIndexerJava.java b/...erver/src/main/java/org/springframework/ide/vscode/boot/java/utils/SpringIndexerJava.java
@@ -299,7 +299,7 @@ public void accept(String docURI, Diagnostic diagnostic) {
  SpringIndexerJavaContext context = new SpringIndexerJavaContext(project, cu, docURI, file,
  lastModified, docRef, content, generatedSymbols, generatedBeans, problemCollector, SCAN_PASS.ONE, new ArrayList<>(), !ignoreMethodBodies);
 
- scanAST(context);
+ scanAST(context, true);
 
  IndexCacheKey symbolCacheKey = getCacheKey(project, SYMBOL_KEY);
  IndexCacheKey beansCacheKey = getCacheKey(project, BEANS_KEY);
@@ -350,7 +350,7 @@ public void accept(ReconcileProblem problem) {
  SpringIndexerJavaContext context = new SpringIndexerJavaContext(project, cu, docURI, file,
  0, docRef, content, generatedSymbols, generatedBeans, voidProblemCollector, SCAN_PASS.ONE, new ArrayList<>(), true);
 
- scanAST(context);
+ scanAST(context, false);
 
  return generatedSymbols.stream().map(s -> s.getEnhancedSymbol()).collect(Collectors.toList());
  });
@@ -408,7 +408,7 @@ public void acceptAST(String sourceFilePath, CompilationUnit cu) {
  SpringIndexerJavaContext context = new SpringIndexerJavaContext(project, cu, docURI, sourceFilePath,
  lastModified, docRef, null, generatedSymbols, generatedBeans, problemCollector, SCAN_PASS.ONE, new ArrayList<>(), !ignoreMethodBodies);
 
- scanAST(context);
+ scanAST(context, true);
 
  dependencies.putAll(sourceFilePath, context.getDependencies());
  scannedTypes.addAll(context.getScannedTypes());
@@ -559,7 +559,7 @@ public void acceptAST(String sourceFilePath, CompilationUnit cu) {
  SpringIndexerJavaContext context = new SpringIndexerJavaContext(project, cu, docURI, sourceFilePath,
  lastModified, docRef, null, generatedSymbols, generatedBeans, problemCollector, pass, nextPassFiles, !ignoreMethodBodies);
 
- scanAST(context);
+ scanAST(context, true);
  progressTask.increment();
  }
  };
@@ -584,7 +584,7 @@ private void addEmptyDiagnostics(Map<String, List<Diagnostic>> diagnosticsByDoc,
  }
  }
 
- private void scanAST(final SpringIndexerJavaContext context) {
+ private void scanAST(final SpringIndexerJavaContext context, boolean includeReconcile) {
  context.getCu().accept(new ASTVisitor() {
 
  @Override
@@ -647,8 +647,9 @@ public boolean visit(MarkerAnnotation node) {
  }
  });
 
-
- reconcile(context);
+ if (includeReconcile) {
+ reconcile(context);
+ }
 
  dependencyTracker.update(context.getFile(), context.getDependencies());;
  }