Duplicate "Source" menu on Eclipse

[mateusbandeiraa]

Describe the bug
After installing the latest version of the Spring Tools 4 plugin on Eclipse 2023-09, the "Source" menu is duplicated when a Java source file is opened.

I was able to reproduce the issue on Windows 11 and MacOS 13.5.2

First menu

Second menu

To Reproduce

1. On a fresh installation of Eclipse IDE for Enterprise Java and Web Developers 2023-09, open the Eclipse Marketplace and install Spring Tools 4.
2. Open a Java source file

Sample

n/a

[BoykoAlex]

Hmm... very interesting... don't think I've seen anything like it yet... I suspect this has something to do when installed from an update sitr as Distro looks good. I'll try to reproduce this

[martinlippert]

Actually, I can reproduce that with both, the latest Spring Tools for Eclipse distribution as well as a plain Eclipse installation with Spring Tools added to it. It appears as soon as you open a Java source file in an editor.

I haven't analyzed the root cause in detail yet, but I guess this is related so some LSP-related format action showing automatically due to the fact that we have the Spring Boot language server registered for the Java source content type.

[BoykoAlex]

Yes, i saw this as well... java editor needs to be active...

[BoykoAlex]

Should be resolved in LSP4E project: eclipse/lsp4e#822

[BoykoAlex]

Fixed in lsp4e. Should be fixed on our side as well once we consume the latest lsp4e snapshot.

[martinlippert]

Since we are not going to ship the upcoming 4.21.1 release with a snapshot version of lsp4e, I moved the target milestone of this to the 4.22.0 release. If you would like to get this fix early, please install/update lsp4e manually from the lsp4e snapshot update site.

[martinlippert]

4.21.1 release will include a new release of lsp4e that includes the fix, therefore closing this as fixed for 4.21.1 here.