Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade dialog to select recipe appears twice #1245

Closed
martinlippert opened this issue May 1, 2024 · 2 comments
Closed

upgrade dialog to select recipe appears twice #1245

martinlippert opened this issue May 1, 2024 · 2 comments
Assignees
Labels
for: eclipse something that is specific for Eclipse theme: refactoring type: bug

Comments

@martinlippert
Copy link
Member

Spring Tools 4 on Eclipse 4.22.1.RELEASE, empty workspace. Created Rest Service guide project.

When I right-click on the project or pom file and execute the `Spring -> Upgrade Spring Boot Version...´, the upgrade dialog where I can select the recipe appears nicely.

When I execute the quick fix to upgrade the boot version first (from the problems view, for example), and then click on the action in the context menu to upgrade spring boot versions, the dialog window appears twice. One of the windows appears to be working (gets the list of recipes in an async way and displays the list), the other one is stuck in the loading phase (at least from the UI perspective).

@BoykoAlex
Copy link
Contributor

This happens because the command for listing recipes is attempted to be executed on the XML LS as well or on any LS started from Eclipse :-
Turns out that computeFirst on language executors really takes the result from the first LS (LS Wrapper) from execution of the request/command on the LS but doesn't skip executing the same on the rest of the LSs. preferServerDefinition only moves the server you'd like to execute request/command on to the top of the list. Therefore to fix this I check if the command is supported by the server as well via server capabilities filter - luckily this command is registered at the server initialization stage.
I have disabled XML LS hence didn't pay enough attention.

@BoykoAlex
Copy link
Contributor

Fixed with 71bcc7a. I'll include it in 4.22.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse theme: refactoring type: bug
Projects
None yet
Development

No branches or pull requests

2 participants