Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Starters sometimes confused whether 'cloud-function' starter is selected #315

Closed
kdvolder opened this issue Jun 28, 2019 · 3 comments
Closed
Milestone

Comments

@kdvolder
Copy link
Member

To reproduce:

  • create a project with 'new spring starter' wizard
  • select the starters called' Reactive Web and `Cloud Function'
  • open 'Edit Starters' wizard on this project.

Notice that only 'Reactive Web' project is recognized as 'currently selected' by the wizard (this is incorrect, since Cloud Function should also be selected).

The reason for this problem is explained here:

@kdvolder
Copy link
Member Author

kdvolder commented Jul 11, 2019

The initializer folks decided not to add the metadata changes that would help us address this problem.

See: spring-io/start.spring.io#169 (comment)

Therefore it will be up to us to find some kind of workaround.

From @mbhave comments in Zoom chat from yesterday, I understand there's probably also a problem with spring session dependency in certain combinations like reddis. I will have to double-check these combinations work and/or fix them as well.

There may be others as well that we are not aware of. Perhaps it is possible for us to just run a kind of automated test of all possible pairs of co-selected dependencies to verify whether the 'reverse pom to selection' function works properly. Not sure this is practical though as there are over 6900 combinations.

The best we can probably do therefore is just fix the cases we are aware of with a simple special-case 'if' test and do this for any/all cases if and when they get reported to us.

@kdvolder
Copy link
Member Author

List of problems detected by a scan of all pairs relating to cloud-function and session in combinations with all other starters:

cloud-starter-consul-config[Consul Configuration] + session[Session]: AssertionFailedError: Project creation failed
cloud-function[Cloud Function] + web[Web]: AssertionError: expected:<[web, cloud-function]> but was:<[web]>
data-redis[Redis] + session[Session]: AssertionError: expected:<[session, data-redis]> but was:<[data-redis]>
cloud-function[Cloud Function] + webflux[Reactive Web]: AssertionError: expected:<[webflux, cloud-function]> but was:<[webflux]>
cloud-starter-zookeeper-config[Zookeeper Configuration] + session[Session]: AssertionFailedError: Project creation failed
data-redis-reactive[Reactive Redis] + session[Session]: AssertionError: expected:<[data-redis-reactive, session]> but was:<[data-redis-reactive]>
jdbc[JDBC] + session[Session]: AssertionError: expected:<[session, jdbc]> but was:<[jdbc]>
data-rest-hal[Rest Repositories HAL Browser] + session[Session]: AssertionFailedError: Project creation failed

@kdvolder
Copy link
Member Author

The 'Project creation failed' are expected apparantly because of bugs in the starters. I have reported these here: spring-io/start.spring.io#191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants