Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitResource schema, add missing properties #671

Closed
kdvolder opened this issue Aug 10, 2021 · 4 comments
Closed

GitResource schema, add missing properties #671

kdvolder opened this issue Aug 10, 2021 · 4 comments

Comments

@kdvolder
Copy link
Member

Related to #668

In that issue's fix added support for fetch_tags property. However, I think there are other missing properties (the editor schema has not been updated in quite a while).

We should:

  • look at all the properties in the documentation for git resource: https:/concourse/git-resource
  • determine which of them are missing from the editor schema
  • add the properties to the schema and hover support and add corresponding test cases.

Note that properties may be missing from either the git resource Source schema but also from the corresponding get and put step schemas.

@kdvolder
Copy link
Member Author

kdvolder commented Aug 10, 2021

Missing from 'GitSource':

  • private_key_user DONE
  • private_key_passphrase DONE
  • forward_agent DONE
  • tag_regex DONE
  • submodule_credentials DONE
  • git_crypt_key DONE
  • https_tunnel DONE
  • commit_filter DONE
  • version_depth DONE

@kdvolder
Copy link
Member Author

kdvolder commented Aug 10, 2021

Missing from GitGetParams schema:

  • fetch_tags DONE
  • short_ref_format DONE
  • timestamp_format DONE
  • describe_ref_options DONE

@kdvolder
Copy link
Member Author

kdvolder commented Aug 10, 2021

Missing from GitPutParams:

  • returning DONE
  • branch DONE

@kdvolder
Copy link
Member Author

Fixes pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants