Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ask user to save dirty editors before deploying on docker #803

Closed
martinlippert opened this issue Aug 1, 2022 · 1 comment
Closed

ask user to save dirty editors before deploying on docker #803

martinlippert opened this issue Aug 1, 2022 · 1 comment
Assignees
Labels

Comments

@martinlippert
Copy link
Member

I have a dirty editor with unsaved changes open.

When I start the corresponding project from the boot dashboard, a dialog shows up and asks me whether I want to save the dirty editor or not. This is correct.

When I deploy the app on docker using the boot dashboard, the build runs and the app gets deployed, and a dialog that asks me about the dirty editor shows up afterwards (which doesn't make a lot of sense). This dialog should be shown upfront, before the build is kicked off.

@martinlippert martinlippert added this to the 4.16.0.RELEASE milestone Aug 1, 2022
@martinlippert martinlippert removed this from the 4.16.0.RELEASE milestone Sep 12, 2022
@nierajsingh nierajsingh self-assigned this Oct 3, 2022
nierajsingh pushed a commit that referenced this issue Oct 3, 2022
When running/debugging docker app, prompt to save dirty editor
@nierajsingh
Copy link
Collaborator

Pushed fix. User is now prompted to save when starting/debugging a docker app if there are dirty editors in the project.

@martinlippert martinlippert added this to the 4.16.1.RELEASE milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants