Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[validation] prepare version validation for 4.17.0 release #904

Closed
martinlippert opened this issue Nov 23, 2022 · 5 comments
Closed

[validation] prepare version validation for 4.17.0 release #904

martinlippert opened this issue Nov 23, 2022 · 5 comments
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring type: enhancement

Comments

@martinlippert
Copy link
Member

In order to prepare for the existing API at https://spring.io/api to go away sometime soon, we decided to realize the following changes for the upcoming 4.17.0 (that we currently use to validate versions and generations of Spring Boot projects):

  • remove the generations validation from the 4.17.0 release. This will be included again in the 4.17.1 release, based on the new API.
  • switch the versions validation to pull version information from maven central instead of the old API.

If possible, we might even query the configured repositories on the projects for the available versions. This would have the benefit of being precise about the available Spring Boot versions in the environment of the user - instead of showing which versions are available in general. But that depends on the amount of work that is necessary to implement this part.

@martinlippert martinlippert added type: enhancement for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring labels Nov 23, 2022
@martinlippert martinlippert added this to the 4.17.0.RELEASE milestone Nov 23, 2022
@BoykoAlex
Copy link
Contributor

BoykoAlex commented Nov 23, 2022

I have moved asking Maven/Gradle repo for available spring-boot versions into a separate issue as this would take some time and effort to implement - see #905.
Otherwise should be good to go for 4.17.0 with:

@martinlippert
Copy link
Member Author

We need to temporarily remove the preferences around the generations checks as well

@martinlippert martinlippert reopened this Nov 24, 2022
@martinlippert
Copy link
Member Author

From looking at the code, it is still fetching the generations information and fails if that information is not around. I will take a deeper look to disable this altogether, not fetching any information, and especially not failing if this information is not around - since we don't do generation validation for this release.

@BoykoAlex
Copy link
Contributor

@martinlippert I can finish this off... resolved this in a hurry unfortunately.

@BoykoAlex
Copy link
Contributor

Seems to be fixed with 8f3e0f3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants