Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checksums at download page #906

Closed
manueljordan opened this issue Nov 28, 2022 · 6 comments
Closed

Add checksums at download page #906

manueljordan opened this issue Nov 28, 2022 · 6 comments
Labels
for: eclipse something that is specific for Eclipse type: enhancement type: install-issue

Comments

@manueljordan
Copy link

Not sure if it is the correct place but, here we go.

Currently at https://spring.io/tools is possible download in peace STS4 according to all OS, but where are the checksums? I think would be nice add them.

Consider it as a friendly suggestion.

@martinlippert
Copy link
Member

We have checksum files around (replace the file extension in the download link with .md5 or sha1, but due to the downloads being available via https only, I am not sure whether you really need a checksum to verify. Nevertheless, you can find them there. We should probably update sha1 to sha256 though.

@martinlippert martinlippert added for: eclipse something that is specific for Eclipse type: install-issue and removed status: waiting-for-triage labels Nov 28, 2022
@manueljordan
Copy link
Author

You are the expert here, but I just confirmed that Gradle and Maven for example have/use https to download their installers too and offer the checksum.

@martinlippert
Copy link
Member

martinlippert commented Dec 1, 2022

I updated the build to produce checksums in SHA-256 now instead of SHA-1, so from the upcoming 4.17.0 release onwards you can get the checksums by replacing the file extension of the general distribution download links with .md5 or .sha256 and get the checksums. Hope this works for you. And thanks for raising this, much appreciated.

@martinlippert martinlippert added this to the 4.17.0.RELEASE milestone Dec 1, 2022
@martinlippert
Copy link
Member

martinlippert commented Dec 1, 2022

But we will not add direct links to the checksums to the download page - to avoid too much clutter in that area.

@manueljordan
Copy link
Author

Understood, but I think is wise add an indication about your approach in the page - btw really is enough add only the .md5 or .sha256 to the current URL, so is not necessary replace the file extension.

@martinlippert
Copy link
Member

Haha, you are absolutely right, not replace the file extension, just append it. My fault. Thanks for pointing that out!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse type: enhancement type: install-issue
Projects
None yet
Development

No branches or pull requests

2 participants