Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test MavenProjectParser #918

Closed
BoykoAlex opened this issue Dec 6, 2022 · 1 comment
Closed

Unit test MavenProjectParser #918

BoykoAlex opened this issue Dec 6, 2022 · 1 comment
Assignees
@BoykoAlex
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: internal-architecture theme: refactoring type: enhancement
Milestone
4.17.2.RELEASE

Comments

@BoykoAlex
Copy link
Contributor

Some tests for MavenProjectParser would be useful. For example test that resources you're expected to be parsed and present in the list of sources, only them and nothing more.
It is important to have a grip over resources being parsed for example not to parse files especially POM's from the output folder (i.e. /target or /bin)
@BoykoAlex BoykoAlex self-assigned this Dec 6, 2022
@martinlippert martinlippert added theme: internal-architecture for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring and removed status: waiting-for-triage labels Dec 7, 2022
@martinlippert martinlippert added this to the 4.17.1.RELEASE milestone Dec 7, 2022
@BoykoAlex
Copy link
Contributor Author

Addressed for now with c8b12a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BoykoAlex BoykoAlex

Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: internal-architecture theme: refactoring type: enhancement
Projects
None yet
Milestone
4.17.2.RELEASE
Development

No branches or pull requests
2 participants
@martinlippert @BoykoAlex