Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boot-upgrade] [Spring-Security] Removed WebSecurityConfigurerAdapter #979

Closed
BoykoAlex opened this issue Feb 17, 2023 · 4 comments
Closed
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring type: enhancement

Comments

@BoykoAlex
Copy link
Contributor

The WebSecurityConfigurerAdapter is deprecated in the last versions of Spring-Security 5.x used in Spring-Boot 2.7.x. As of Spring-Security 6.x and Spring-Boot 3.x the WebSecurityConfigurerAdapter is removed.

Migration guide for the Removed WebSecurityConfigurerAdapter

The migration guide splits migration in 5 cases (parts are completed in WebSecurityConfigurerAdapter recipe in rewrite-spring project:

  • HttpSecurity (done)
  • WebSecurity (done)
  • Authentication
    • In-Memory (done)
    • LDAP
    • JDBC

Remaining cases are LDAP and JDBC authentication which seem challenging as methods bodies requires significant changes even going outside the scope of one method. Looks like only some migration cases are possible to cover with rewrite. It is challenging to write code that would reliably determine conditions when it is possible to perform automated migration.

@martinlippert martinlippert added for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring and removed status: waiting-for-triage labels Feb 24, 2023
@martinlippert martinlippert added this to the Backlog milestone Feb 24, 2023
@BoykoAlex
Copy link
Contributor Author

Marker and quickfix added to IDE: 7c5dee4

@martinlippert martinlippert modified the milestones: Backlog, 4.18.0.RELEASE Feb 27, 2023
@BoykoAlex
Copy link
Contributor Author

BoykoAlex commented Mar 9, 2023

Done for 4.18.0 release.
This is to be continued in future releases.
The overall plan is:

  1. Modify the recipe to comment out methods that cannot be migrated and include the recipe into Boot 3 upgrade.
  2. Handle LDAP and JDBC authentication config cases

@martinlippert
Copy link
Member

So we can close this one and open new and separate issues for the work to be continued in the 4.18.1 cycle? (@BoykoAlex )

@BoykoAlex
Copy link
Contributor Author

Remaining bits moved to #1001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants