Allow GitHub Actions workflow trigger for pull requests

[dhs3000]

We have some halfpipe manifests that are used to create GH Action workflows to execute tests against a pull request.

Currently, halfpipe only supports the push event to trigger a run. For our use case, we need to manually change the generated workflow to use pull_request event.

It would be great if this could be somehow supported in halfpipe directly, as it makes it much easier to the developers to use only one "configuration language" (halfpipe).

[robwhitby]

yep this is an area we need to think about more, could you link to an example where you use halfpipe for PRs? I'm interested in whether halfpipe makes sense for these kind of simpler/additional workflows or maybe we should be looking more at reusable workflows for standardisation.

[dhs3000]

There is for example these two examples:

• workflow / halfpipe file
• workflow / halfpipe file

Yes, maybe these reusable workflows could be a good fit. The workflows differ in the watched/ignored paths, injected environment variables/secrets, and the one tasks that is executed (some use docker compose, some directly a docker image&script. The latter could be moved to docker compose I assume, to reduce differences).

[efasel]

Looks like we would not be able to provide a private shared pool of reusable workflows only accessible from within the SN org. :-\

from Access to reusable workflows — Reusing workflows - GitHub Docs

A reusable workflow can be used by another workflow if either of the following is true:

• Both workflows are in the same repository.
• The called workflow is stored in a public repository, and your organization allows you to use public reusable workflows.

On the other hand in Overview — Reusing workflows - GitHub Docs it says:

Your organization can build up a library of reusable workflows that can be centrally maintained.

And in that case this might be a good fit, yes!

I guess we have to try to find out. 🙂

[robwhitby]

luckily internal counts as public in this case, I already have one working:

https:/springernature/ee-github-actions

reusable deploy to snpaas workflow

example repo using it

I think it has good potential, we're just in a spiking phase though, there are some quirks and limitations to learn about