Fix deprecation in Python 3.12 #511
Conversation
|
@spulec I recommend merging this PR. It will resolve an outstanding DeprecationWarning in Python 3.12, which was released on Monday. |
|
Hey, second person looking at the 3.12 breakage (full disclosure, @kurtmckee and I work together 🙂 )! I think the person whose attention we need is @boxed, who appears to have commit access on this repo. |
|
@sirosen I do not. I have switched to time-machine long ago and I recommend you do too. |
|
I'm surprised/confused by this. The most recently merged PRs appear to be done by you in February, which is why I assumed you'd be able to help patch this.
... thanks for this recommendation! Looking into it for all of two minutes shows that it's from a maintainer with a decent track record for keeping projects healthy long-term, and it looks like nearly a drop-in replacement. I'll start looking into this for our team's needs. |
|
@sirosen This project has been functionally abandoned for several years. I tried to fix that for a while. Then I found out that time-machine exists. |
We just tried this and it doesn't support pypy, which is a bit of a blocker to migrating over. |
While working on python 3.12 compatibility fixes I found a comment from the freezegun maintainer [1] saying the library was functionally abandoned and that they had moved on to time-machine. Time-machine looks well maintained and has a fairly trivial conversion story along with docs for just that. 1: spulec/freezegun#511 (comment)
While working on python 3.12 compatibility fixes I found a comment from the freezegun maintainer [1] saying the library was functionally abandoned and that they had moved on to time-machine. Time-machine looks well maintained and has a fairly trivial conversion story along with docs for just that. 1: spulec/freezegun#511 (comment)
We decided to switch anyway, skipping the test on Pypy, but now we have reports from downstream packagers that time-machine segfaults when they run it. So far it is not looking like the best replacement for freezegun, and is a shame that this is not being maintained anymore... |
|
Thanks @bblommers! I see you're listed as a maintainer on PyPI -- would you be willing to push a release to address this? |
|
Done @kurtmckee! 1.3.0 is now out. |
Fixes #508.